Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to calling Errorf instead of Fatalf from Cleanup #46

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

JosiahWitt
Copy link
Owner

@JosiahWitt JosiahWitt commented Jun 28, 2021

Keeps panics that are raised after the chain is built from being silenced.

For example, this used to fail the test with only Found ensure(<actual>) without chained assertion., when the error was actually a panic. Now the full panic will be shown.

someSmallSlice := []string{"one item"}
ensure("hi").Equals(someSmallSlice[10000])

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #46 (550d4d6) into master (fd3a99f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           6        6           
  Lines         437      437           
=======================================
  Hits          434      434           
  Misses          2        2           
  Partials        1        1           
Impacted Files Coverage Δ
ensurepkg/ensurepkg.go 91.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3a99f...550d4d6. Read the comment docs.

@JosiahWitt JosiahWitt merged commit 2761c25 into master Jun 28, 2021
@JosiahWitt JosiahWitt deleted the cleanup-error branch June 28, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants