Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report package history in PkgEval summaries #170

Merged
merged 12 commits into from
Aug 2, 2023

Conversation

LilithHafner
Copy link
Contributor

In theory, the result should look like this:
Screenshot 2023-07-31 at 5 20 58 PM
I changed from list to table because aligning histories can elucidate when historical failures are a package's fault vs. Julia's fault.

Also in theory, it should be possible to load historical results from local storage on the Nanosoldier machines. However, I am not familiar with those machines, so I implemented a portable version that downloads them from github so that I can test my implementation locally.

@maleadt
Copy link
Member

maleadt commented Aug 1, 2023

Really nice, thanks!

Also in theory, it should be possible to load historical results from local storage on the Nanosoldier machines.

Yeah I'll probably rework it so that we re-use the local storage, since the AWS buckets have a fairly limited lifetime associated with them.

@LilithHafner
Copy link
Contributor Author

This doesn't download from aws buckets, only https://github.com/JuliaCI/NanosoldierReports/tree/master/pkgeval/by_date/.

Is it possible to view the markdown summary generated in CI?

@maleadt
Copy link
Member

maleadt commented Aug 1, 2023

This doesn't download from aws buckets, only https://github.com/JuliaCI/NanosoldierReports/tree/master/pkgeval/by_date/.

Oh, right. Still, doesn't seem ideal to hit GitHub for these, especially when we have the reports repository cloned locally. In fact, we already use the local clone to find the previous date:

function retrieve_daily_pkgeval_data!(cfg, date)
dailydir = joinpath(reportdir(cfg), "pkgeval", "by_date", datedirname(date))
isdir(dailydir) || return nothing
# NOTE: we don't actually use the data from the previous day, just the
# build properties, since packages upgrades might cause failures too.
dbpath = joinpath(dailydir, "db.json")
isfile(dbpath) || return nothing
db = JSON.parsefile(dbpath)
return db
end

Is it possible to view the markdown summary generated in CI?

It's currently not published anywhere, no.

@maleadt
Copy link
Member

maleadt commented Aug 2, 2023

Great, let's try this out!

@maleadt maleadt merged commit 29469ae into JuliaCI:master Aug 2, 2023
@LilithHafner LilithHafner deleted the report-pkgeval-history branch August 3, 2023 11:37
@LilithHafner LilithHafner restored the report-pkgeval-history branch August 3, 2023 11:37
@LilithHafner
Copy link
Contributor Author

LilithHafner commented Aug 3, 2023

The markdown report in CI did not successfully show a plot, but I suppose we'll see if it works in production

Edit: it did not JuliaLang/julia@3c64bc3#commitcomment-123412580

@LilithHafner LilithHafner deleted the report-pkgeval-history branch August 3, 2023 11:43
LilithHafner referenced this pull request in JuliaLang/julia Aug 5, 2023
This can be a problem for very long function bodies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants