-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report package history in PkgEval summaries #170
Conversation
Really nice, thanks!
Yeah I'll probably rework it so that we re-use the local storage, since the AWS buckets have a fairly limited lifetime associated with them. |
This doesn't download from aws buckets, only https://github.com/JuliaCI/NanosoldierReports/tree/master/pkgeval/by_date/. Is it possible to view the markdown summary generated in CI? |
Oh, right. Still, doesn't seem ideal to hit GitHub for these, especially when we have the reports repository cloned locally. In fact, we already use the local clone to find the previous date: Nanosoldier.jl/src/jobs/PkgEvalJob.jl Lines 291 to 302 in 26ce3fb
It's currently not published anywhere, no. |
This is less bandwidth in production in exchange for more bandwidth during testing. Also, git clone from github on a github runner should be cheap.
Great, let's try this out! |
The markdown report in CI did not successfully show a plot, but I suppose we'll see if it works in production Edit: it did not JuliaLang/julia@3c64bc3#commitcomment-123412580 |
This can be a problem for very long function bodies.
In theory, the result should look like this:
I changed from list to table because aligning histories can elucidate when historical failures are a package's fault vs. Julia's fault.
Also in theory, it should be possible to load historical results from local storage on the Nanosoldier machines. However, I am not familiar with those machines, so I implemented a portable version that downloads them from github so that I can test my implementation locally.