Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test failures for build uploads when not on release branch or tags #420

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified pipelines/main/launch_signed_jobs.yml.signature
Binary file not shown.
9 changes: 9 additions & 0 deletions pipelines/main/launch_upload_jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ steps:
export BUILDKITE_PLUGIN_CRYPTIC_BASE64_SIGNED_JOB_ID_SECRET
export ALLOW_FAIL="false"

# allow test-failures for non-release/tags so that nightly & PR builds
# can be uploaded to s3 even if tests are not passing
# (allowing for usage with juliaup)
export ALLOW_TEST_FAILURES=$(([[ "${BUILDKITE_BRANCH?}" == release-* ]] || [[ "${BUILDKITE_TAG:-}" == v* ]]) && echo "false" || echo "true")
##### Launch `upload_*` jobs to store tarballs into S3 once tests are done
### Linux:
# Regular Linux upload jobs:
Expand Down Expand Up @@ -82,6 +86,11 @@ steps:
export BUILDKITE_PLUGIN_CRYPTIC_BASE64_SIGNED_JOB_ID_SECRET

export ALLOW_FAIL="true"

# allow test-failures for non-release/tags so that nightly & PR builds
# can be uploaded to s3 even if tests are not passing
# (allowing for usage with juliaup)
export ALLOW_TEST_FAILURES=$(([[ "${BUILDKITE_BRANCH?}" == release-* ]] || [[ "${BUILDKITE_TAG:-}" == v* ]]) && echo "false" || echo "true")

# Launch Linux allowed-to-fail upload jobs
GROUP="Allow Fail (Upload)" \
Expand Down
Binary file modified pipelines/main/launch_upload_jobs.yml.signature
Binary file not shown.
3 changes: 2 additions & 1 deletion pipelines/main/platforms/upload_freebsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ steps:
# Wait for the builder to finish
- "build_${TRIPLET?}"
# Wait for the tester to finish
- "test_${TRIPLET?}"
- step: "test_${TRIPLET?}"
allow_failure: "${ALLOW_TEST_FAILURES?}"
# Prevent multiple pipelines from uploading to S3 simultaneously
# It is okay for two different triplets to upload simultaneously
concurrency: 1
Expand Down
3 changes: 2 additions & 1 deletion pipelines/main/platforms/upload_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ steps:
# Wait for the builder to finish
- "build_${TRIPLET?}"
# Wait for the tester to finish
- "test_${TRIPLET?}"
- step: "test_${TRIPLET?}"
allow_failure: "${ALLOW_TEST_FAILURES?}"
# Prevent multiple pipelines from uploading to S3 simultaneously
# It is okay for two different triplets to upload simultaneously
concurrency: 1
Expand Down
3 changes: 2 additions & 1 deletion pipelines/main/platforms/upload_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ steps:
# Wait for the builder to finish
- "build_${TRIPLET?}"
# Wait for the tester to finish
- "test_${TRIPLET?}"
- step: "test_${TRIPLET?}"
allow_failure: "${ALLOW_TEST_FAILURES?}"
# Prevent multiple pipelines from uploading to S3 simultaneously
# It is okay for two different triplets to upload simultaneously
concurrency: 1
Expand Down
3 changes: 2 additions & 1 deletion pipelines/main/platforms/upload_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ steps:
# Wait for the builder to finish
- "build_${TRIPLET?}"
# Wait for the tester to finish
- "test_${TRIPLET?}"
- step: "test_${TRIPLET?}"
allow_failure: "${ALLOW_TEST_FAILURES?}"
# Prevent multiple pipelines from uploading to S3 simultaneously
# It is okay for two different triplets to upload simultaneously
concurrency: 1
Expand Down
2 changes: 1 addition & 1 deletion pipelines/scheduled/coverage/coverage.yml.signature
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Salted__Ϫ��+�<5�Z-���ڬҹƲʛJ("�u�e�U z��h�b���@��<i�O�b������͛�.Z��7�R��2�j
Salted__����E�ϞZ�-��V�il���t�V��H�����e����h�_���)��W�j�A��oF�51��U�N��Z�Uzw3�2ʗXM�G$�h�
Binary file modified pipelines/scheduled/launch_signed_jobs.yml.signature
Binary file not shown.
Binary file modified pipelines/scheduled/launch_upload_jobs.yml.signature
Binary file not shown.