Selectively reduce multithreaded parsing @error #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the
@error
introduced in #1073 to a@warning
whenever previous warnings may explain why multithreaded parsing failed (typically, unequal number of columns per row). In those cases, it will print:If there is no possible explanation, this still shows a red
@error
saying:In both cases, a debug statement is printed as soon as multithread parsing failed (if the Context
debug
kwarg is set), whereas the@warning
or@error
only appears at the end of the fallback single-threaded parsing.I think this compromise allows us to still get error reports like #1095, which are crucial to detect and allow use to fix underlying issues where multithreaded parsing should not fail (like #1098 in this instance), while avoiding to stress the user with an
@error
when there is nothing to report.Close #1095.