Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier show function #881

Closed
gdkrmr opened this issue Nov 3, 2015 · 8 comments
Closed

prettier show function #881

gdkrmr opened this issue Nov 3, 2015 · 8 comments

Comments

@gdkrmr
Copy link
Contributor

gdkrmr commented Nov 3, 2015

the show function for DataFrame could be nicer, here is a proposal:

dataframe_show_function

@johnmyleswhite
Copy link
Contributor

Please write a pull request and we'll review it. It's unlikely we'll change this functionality, though.

@StefanKarpinski
Copy link
Member

+1 – I like that display much better.

@gdkrmr
Copy link
Contributor Author

gdkrmr commented Nov 4, 2015

there are also different styles, any suggestions? https://en.wikipedia.org/wiki/Box-drawing_character

@nalimilan
Copy link
Member

Good idea, but why not drop the vertical lines entirely? In many scientific publications, tables are drawn without them, and the result is quite good. The alignment of contents is enough for the eye to identify the columns.

If people still prefer the version with lines, I'd vote for the less heavy character available, e.g. (U+2502). It would also help if the REPL stopped using bold by default (JuliaLang/julia#11250).

@gdkrmr
Copy link
Contributor Author

gdkrmr commented Nov 8, 2015

Light vertical lines, bold horizontal lines:
dataframe_show_function_verical_light

@nalimilan
Copy link
Member

Do you have any idea about how to make the vertical lines join?

@gdkrmr
Copy link
Contributor Author

gdkrmr commented Nov 8, 2015

The problem is the space between lines in the terminal which cannot be
changed in most terminal emulators, I think it is possible in iterm.

On 08.11.2015 16:25, Milan Bouchet-Valat wrote:

Do you have any idea about how to make the vertical lines join?


Reply to this email directly or view it on GitHub
#881 (comment).

@nalimilan
Copy link
Member

Fixed by #888.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants