add BroadcastedInvertedIndex for InvertedIndex broadcasting #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan - I have added the list of expected scenarios in tests. Also it seems this repo does not have a CI set up. Do you easily know how to add GitHub Actions? (I never remember it) Thank you! |
nalimilan
reviewed
Sep 2, 2021
Co-authored-by: Milan Bouchet-Valat <[email protected]>
bkamins
commented
Sep 2, 2021
bkamins
commented
Sep 2, 2021
bkamins
commented
Sep 2, 2021
bkamins
commented
Sep 2, 2021
nalimilan
reviewed
Sep 3, 2021
Co-authored-by: Milan Bouchet-Valat <[email protected]>
bkamins
commented
Sep 4, 2021
|
Fixed. However the CI does not seem to trigger :) |
|
That was because at #26 I copied a config for |
nalimilan
approved these changes
Sep 4, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15