Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at addressing #13. It is still WIP (I've only done the case with known schema, haven't added tests and have probably forgotten to added the
unwrap
keyword in a few places) and lacks tests but I hope is good enough to give an idea. It works as follows:the user passes a
unwrap
optional argument (defaults tot -> false
) that specifies what types should be unwrapped. So the default behavior is unchanged:From experimentation in StructArrays the compiler is quite good here so it figures out the value of
unwrap(T)
in advance (at least in general I couldn't find traces ofunwrap
in@code_llvm
and results were inferred correctly).In #13 I was wrong: there's actually no need to add extra
setindex!
orpush!
method provided one is a bit careful in the definition ofadd!