If strict=true and a @repl block throws an exception, the build should fail

[DilumAluthge]

Before this PR:

strict	Block that throws an exception	Build result
true	@example	❌ fail
true	@repl	✅ pass
false	@example	✅ pass
false	@repl	✅ pass

After this PR:

strict	Block that throws an exception	Build result
true	@example	❌ fail
true	@repl	❌ fail
false	@example	✅ pass
false	@repl	✅ pass

This is a breaking change.

[DilumAluthge]

@mortenpi This PR takes care of the global behavior.

We still need the ability to opt-out on a per-block basis via the allowexceptions keyword. I'm not sure how to implement that, so I left it out of this PR. If you can assist me, we can put it in this PR. Or we can put it into a future PR.

[mortenpi]

I think it would be good to do allowexceptions together with this change, so it would be easy for people who are relying on errors in at-repl to upgrade.

Re implementation: I think our current state of the art for keyword handling is this:

Documenter.jl/src/Expanders.jl

Lines 539 to 540 in 9801cf4

	# "parse" keyword arguments to example (we only need to look for continued = true)
	continued = occursin(r"continued\s*=\s*true", x.language)

I've always felt that we should have a function that takes the at-block lang. string and returns something that contains all the positional and keyword arguments. Maybe even relying on Meta.parse for the parsing? That said, a simple regex could also do. I think that's all we'd need?

[mortenpi]

If we're explicitly allowing exceptions, I don't think we want to write anything to the terminal? Could always turn it into an @debug though.

[DilumAluthge]

Yeah @debug sounds good.

[DilumAluthge]

Changed to @debug

[mortenpi]

I think our current state of the art for keyword handling is this

Actually, the state of the art is in doctests, so we should probably generalize that:

Documenter.jl/src/DocTests.jl

Lines 124 to 156 in 9801cf4

	if startswith(lang, "jldoctest")
	# Define new module or reuse an old one from this page if we have a named doctest.
	name = match(r"jldoctest[ ]?(.*)$", split(lang, ';', limit = 2)[1])[1]
	sym = isempty(name) ? gensym("doctest-") : Symbol("doctest-", name)
	sandbox = get!(() -> Expanders.get_new_sandbox(sym), ctx.meta, sym)
	# Normalise line endings.
	block = MutableMD2CodeBlock(block_immutable)
	block.code = replace(block.code, "\r\n" => "\n")
	# parse keyword arguments to doctest
	d = Dict()
	idx = findfirst(c -> c == ';', lang)
	if idx !== nothing
	kwargs = Meta.parse("($(lang[nextind(lang, idx):end]),)")
	for kwarg in kwargs.args
	if !(isa(kwarg, Expr) && kwarg.head === :(=) && isa(kwarg.args[1], Symbol))
	file = ctx.meta[:CurrentFile]
	lines = Utilities.find_block_in_file(block.code, file)
	@warn("""
	invalid syntax for doctest keyword arguments in $(Utilities.locrepr(file, lines))
	Use ```jldoctest name; key1 = value1, key2 = value2
	```$(lang)
	$(block.code)
	```
	""")
	return false
	end
	d[kwarg.args[1]] = Core.eval(sandbox, kwarg.args[2])
	end
	end
	ctx.meta[:LocalDocTestArguments] = d

[mortenpi]

Just to check in with this: it just needs argument handling for the relevant at-blocks to locally set allowexceptions and it should be good to go I think?

[DilumAluthge]

Just to check in with this: it just needs argument handling for the relevant at-blocks to locally set allowexceptions and it should be good to go I think?

Yep. I'll take a stab at implementing the keyword handling.

[DilumAluthge]

It's been a while since I looked at this.

@mortenpi Can you remind me where I should look to figure out how to handle the keyword arguments?