Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findmax, findmin, argmax, and argmin #42

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add findmax, findmin, argmax, and argmin #42

merged 2 commits into from
Jan 19, 2022

Conversation

tkf
Copy link
Member

@tkf tkf commented Jan 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #42 (941ae69) into master (7229305) will increase coverage by 0.08%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   82.16%   82.25%   +0.08%     
==========================================
  Files           7        7              
  Lines         342      355      +13     
==========================================
+ Hits          281      292      +11     
- Misses         61       63       +2     
Flag Coverage Δ
unittests 82.25% <84.61%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Folds.jl 100.00% <ø> (ø)
src/testing.jl 88.61% <ø> (ø)
src/utils.jl 44.68% <75.00%> (+2.82%) ⬆️
src/reduce.jl 93.04% <88.88%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7229305...941ae69. Read the comment docs.

@tkf tkf enabled auto-merge (squash) January 19, 2022 18:09
@tkf tkf merged commit e22ddea into master Jan 19, 2022
@tkf tkf deleted the findmax branch January 19, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant