Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call next on dummy; it's not pure #76

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Don't call next on dummy; it's not pure #76

merged 3 commits into from
Jul 19, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Jul 19, 2021

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #76 (5caeb8d) into master (63968d9) will decrease coverage by 4.27%.
The diff coverage is 3.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   55.48%   51.20%   -4.28%     
==========================================
  Files           2        2              
  Lines         155      166      +11     
==========================================
- Hits           86       85       -1     
- Misses         69       81      +12     
Flag Coverage Δ
Pkg.test-cpu ?
Run.test-cpu 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/kernels.jl 49.36% <3.70%> (-4.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63968d9...5caeb8d. Read the comment docs.

@tkf tkf enabled auto-merge (squash) July 19, 2021 19:20
@tkf tkf merged commit 9ad7659 into master Jul 19, 2021
@tkf tkf deleted the sideeffects branch July 19, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant