Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Union values in shfl-based kernel #80

Merged
merged 10 commits into from
Jul 20, 2021
Merged

Support Union values in shfl-based kernel #80

merged 10 commits into from
Jul 20, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Jul 19, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #80 (29d0a77) into master (5aab516) will decrease coverage by 4.08%.
The diff coverage is 17.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   48.52%   44.44%   -4.09%     
==========================================
  Files           3        4       +1     
  Lines         305      369      +64     
==========================================
+ Hits          148      164      +16     
- Misses        157      205      +48     
Flag Coverage Δ
Pkg.test-cpu ?
Run.test-cpu 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api.jl 90.00% <ø> (ø)
src/kernels.jl 48.44% <0.00%> (-0.92%) ⬇️
src/unionvalues.jl 18.18% <18.18%> (ø)
src/shfl.jl 46.85% <21.42%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aab516...29d0a77. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Jul 19, 2021

julia> xs = CUDA.ones(2^30);

julia> @btime sum(xs);
  7.057 ms (1764 allocations: 29.72 KiB)

julia> @btime Folds.sum(xs);
  160.098 ms (78557 allocations: 1.20 MiB)

julia> @btime Folds.sum(xs, CoalescedCUDAEx(); init = 0.0f0);
  8.192 ms (3038 allocations: 50.98 KiB)

@tkf tkf enabled auto-merge (squash) July 20, 2021 00:09
@tkf tkf merged commit 9ea2710 into master Jul 20, 2021
@tkf tkf deleted the unionvalue branch July 20, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant