Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for complete with side effects #86

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fix for complete with side effects #86

merged 2 commits into from
Jul 20, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Jul 20, 2021

This is found while testing reduce_partition_by.jl.

This is found while testing reduce_partition_by.jl.
@tkf tkf enabled auto-merge (squash) July 20, 2021 21:38
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #86 (c20e125) into master (0aec3b4) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   48.24%   48.26%   +0.01%     
==========================================
  Files           5        5              
  Lines         371      375       +4     
==========================================
+ Hits          179      181       +2     
- Misses        192      194       +2     
Flag Coverage Δ
Pkg.test-cpu 3.76% <0.00%> (-0.05%) ⬇️
Run.test-cpu 3.76% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/kernels.jl 52.28% <50.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aec3b4...c20e125. Read the comment docs.

@tkf tkf merged commit 9b523f2 into master Jul 20, 2021
@tkf tkf deleted the test-reduce_partition_by branch July 20, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant