Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable equality for Dedupe #518

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

jonalm
Copy link
Contributor

@jonalm jonalm commented Mar 4, 2022

fixes #517

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #518 (76b68fc) into master (39038b2) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   93.52%   93.75%   +0.23%     
==========================================
  Files          32       32              
  Lines        2225     2227       +2     
==========================================
+ Hits         2081     2088       +7     
+ Misses        144      139       -5     
Flag Coverage Δ
Pkg.test 89.66% <100.00%> (+<0.01%) ⬆️
Run.test 93.57% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/library.jl 95.57% <100.00%> (+0.01%) ⬆️
src/groupby.jl 90.47% <0.00%> (+1.58%) ⬆️
src/core.jl 93.02% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39038b2...76b68fc. Read the comment docs.

@tkf tkf changed the title first try implementation Customizable equality for Dedupe Mar 5, 2022
@tkf tkf enabled auto-merge (squash) March 5, 2022 06:13
@tkf tkf merged commit 7ef1de0 into JuliaFolds:master Mar 5, 2022
@tkf
Copy link
Member

tkf commented Mar 5, 2022

Thanks for the patch! Registering JuliaRegistries/General#56024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametric equality function in Dedupe
2 participants