Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix == on Reductions #545

Merged
merged 1 commit into from
Nov 27, 2022
Merged

fix == on Reductions #545

merged 1 commit into from
Nov 27, 2022

Conversation

MasonProtter
Copy link
Member

Closes #540

@MasonProtter MasonProtter enabled auto-merge (squash) November 27, 2022 20:12
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #545 (a7e7ea1) into master (bd958e4) will decrease coverage by 0.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   95.43%   94.84%   -0.59%     
==========================================
  Files          32       32              
  Lines        2232     2231       -1     
==========================================
- Hits         2130     2116      -14     
- Misses        102      115      +13     
Flag Coverage Δ
Pkg.test 94.46% <100.00%> (-0.09%) ⬇️
Run.test 94.71% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core.jl 92.12% <100.00%> (-0.90%) ⬇️
src/basics.jl 88.88% <0.00%> (-5.56%) ⬇️
src/partitionby.jl 90.90% <0.00%> (-3.90%) ⬇️
src/nondeterministic_threading.jl 88.77% <0.00%> (-2.05%) ⬇️
src/reduce.jl 94.59% <0.00%> (-1.84%) ⬇️
src/progress.jl 91.58% <0.00%> (-0.94%) ⬇️
src/library.jl 98.70% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MasonProtter MasonProtter merged commit 142abcb into master Nov 27, 2022
@MasonProtter MasonProtter deleted the fix-eq-reduction branch November 27, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduction falls back on === inappropriately
1 participant