Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9 Extensions #5

Merged
merged 31 commits into from
Jun 26, 2023
Merged

Conversation

longemen3000
Copy link
Contributor

@longemen3000 longemen3000 commented May 16, 2023

adds BlockArrays, DataFrames, LazyArrays, OnlineStatsBase, Referenceables as extensions. lets start with those, and if tests pass, then add the unconditional dependencies as extensions.

@longemen3000
Copy link
Contributor Author

I would really benefit for testing 1.9 here 😅, as the only version that uses extensions is nightly, and it seems to have an error that i cannot reproduce on 1.9

longemen3000 and others added 2 commits May 17, 2023 01:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@longemen3000
Copy link
Contributor Author

for some reason, the inference test on Referenceables.referenceable is failing

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MasonProtter
Copy link
Member

Ugh, I'm sorry, I tried to switch away from the old CI infrastructure hoping that might make this easier but it seems to have just introduced a new nest of problems. Maybe just rewind your branch to before my commits.

@longemen3000
Copy link
Contributor Author

@MasonProtter tests pass (with the new CI). There was a genuine bug on 32 bit that was fixed and another on OnlineStatsBase. Can we merge this?

@MasonProtter
Copy link
Member

Awesome, thank you @longemen3000!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MasonProtter MasonProtter merged commit 6540960 into JuliaFolds2:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants