Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reshape #20

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix reshape #20

wants to merge 5 commits into from

Conversation

benedict-96
Copy link
Collaborator

@benedict-96 benedict-96 commented Dec 8, 2024

Fixes #19
Fixes #18
Introduces a keyword argument reduce that specifies which operation should be used to perform mapreduce in build_nn_function (and similar functions).

But introduces type pyracy! Maybe Fixes #18 should be fixed by doing a pr in SymbolicUtils.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (8d610cc) to head (0ed585f).

Files with missing lines Patch % Lines
src/utils/build_function2.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   72.30%   73.45%   +1.14%     
==========================================
  Files          16       17       +1     
  Lines         325      339      +14     
==========================================
+ Hits          235      249      +14     
  Misses         90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…s of neural network parameters or other expressions.
@benedict-96 benedict-96 marked this pull request as draft December 9, 2024 09:55
@benedict-96
Copy link
Collaborator Author

NOTE: This pr is set to "draft" until JuliaSymbolics/SymbolicUtils.jl#644 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reshape used in the wrong way create_array for ReshapedArray not defined
1 participant