Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WebIO provider into Blink #200

Closed
twavv opened this issue Jun 8, 2019 · 2 comments
Closed

Move WebIO provider into Blink #200

twavv opened this issue Jun 8, 2019 · 2 comments

Comments

@twavv
Copy link
Member

twavv commented Jun 8, 2019

Blink already depends on WebIO (in the sense that it's in the project's requirements) and the provider code in WebIO relies on hacks to properly display in Blink.

I'm happy to make a PR but would probably need some guidance.

@twavv
Copy link
Member Author

twavv commented Jun 8, 2019

Looking at the Blink provider code in WebIO, the following comes to mind.

We need a connection to use to communicate between WebIO and Blink.

Currently, the connection is instantiated whenever a WebIO thing is displayed in the frontend and uses Blink's preexisting messaging infrastructure. We could do something similar and just create a new BlinkConnection (would probably be renamed to WebIOConnection if moved into Blink) every time a WebIO node is body!-ed, but we could also just have it be per-page. There's not a lot of overhead in the current way of doing things so it might not be worth trying to make this better.

Consistency between Julia and JS interfaces

I actually started writing this section thinking that this was going to be very hard - but it's not.

Currently, WebIO bundles the requisite JS for all the providers which makes it easy to keep in sync when things change in how data is communicated between Julia and the browser. Essentially, Blink should just maintain it's own provider JS; this is very simple - all it does is tell WebIO how to send messages (i.e. using Blink.msg) and redirect relevant messages to WebIO (i.e. define Blink.handlers.webio).

@twavv
Copy link
Member Author

twavv commented Jul 24, 2019

This is done (will be really really done with #206 :'))

@twavv twavv closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant