Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebIO integration. #206

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Fix WebIO integration. #206

merged 3 commits into from
Jul 24, 2019

Conversation

twavv
Copy link
Member

@twavv twavv commented Jul 23, 2019

This illustrates a need for tests for WebIO.

I will try to write some later, but please merge this first. :^)

@twavv
Copy link
Member Author

twavv commented Jul 23, 2019

ping @NHDaly

@twavv twavv mentioned this pull request Jul 23, 2019
Merged
@twavv twavv changed the title Fix typo for isopen(::WebIOBlinkComm) Fix WebIO integration. Jul 24, 2019
@twavv twavv mentioned this pull request Jul 24, 2019
Closed
ghost
ghost approved these changes Jul 24, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ cool, lgtm! :) Thanks for this fix!

@NHDaly NHDaly merged commit b225494 into JuliaGizmos:master Jul 24, 2019
@NHDaly NHDaly mentioned this pull request Jul 24, 2019
Closed
@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twavv @NHDaly @pfitzseb