Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat bounds for all dependencies. #234

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

twavv
Copy link
Member

@twavv twavv commented Dec 28, 2019

No description provided.

@tkoolen
Copy link
Contributor

tkoolen commented Dec 30, 2019

MacroTools unfortunately also dropped 0.7 support when it dropped 0.6 support for some reason. MacroTools 0.4 should install and work on Julia 0.7, I think.

@twavv
Copy link
Member Author

twavv commented Dec 30, 2019

I was leaning towards dropping 0.7 support (thoughts?).

@tkoolen
Copy link
Contributor

tkoolen commented Dec 30, 2019

That's another option. But it kind of becomes this cascade where now dependencies of this package also need to stop testing on / advertising support for 0.7, and not really for a good technical reason. I think MacroTools 0.4 will be fine for testing on 0.7 for the foreseeable future. And if not, we could always switch then, or submit a trivial PR to MacroTools to change the compat to get their latest.

I believe you do need an upper bound on julia in the compat section to get the version tag auto-merge bot to work by the way.

@twavv
Copy link
Member Author

twavv commented Dec 30, 2019

I see your point but I also don't think 0.7 is in wide use today. Plus it causes some issues with Travis (which are fixable but...).

@tkoolen
Copy link
Contributor

tkoolen commented Dec 30, 2019

Do whatever you think is best. It's not a huge deal either way.

@twavv twavv merged commit 5b2195b into JuliaGizmos:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants