Update communication.md #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
reviewed
Dec 31, 2019
| @@ -78,7 +78,7 @@ pass more or fewer arguments, pass your arguments as an array: | |||
| handle(w, "event") do count, values, message | |||
| # ... | |||
| end | |||
| @js w Blink.msg("event", [1, ['a','b'], "Hi"]); | |||
| @js w Blink.msg("press", [1, ['a','b'], "Hi"]); | |||
There was a problem hiding this comment.
Oops, I actually think this was the wrong fix. The problem is actually with the way the arguments to the "event" handler are declared.
I think what this example was trying to show is that you can to use argument destructuring in order to pass multiple arguments to a handler..
I just opened #238 to fix it. :) Thanks for responding to the issue in the first place! :)
There was a problem hiding this comment.
Ah, I didn't even notice that.
🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222.