Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates macros to Julia 1.6 macro scoping #274

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

andreasnoack
Copy link
Contributor

This should make tests pass on 1.6.

Enable testing on latest release

Enable testing on latest release
@codecov-io
Copy link

Codecov Report

Merging #274 (ed74459) into master (3480c39) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   48.88%   49.28%   +0.39%     
==========================================
  Files          12       12              
  Lines         315      351      +36     
==========================================
+ Hits          154      173      +19     
- Misses        161      178      +17     
Impacted Files Coverage Δ
src/AtomShell/window.jl 43.20% <100.00%> (+1.87%) ⬆️
src/rpc/rpc.jl 75.00% <100.00%> (+2.77%) ⬆️
src/AtomShell/process.jl 64.91% <0.00%> (-9.56%) ⬇️
src/content/server.jl 72.72% <0.00%> (-1.64%) ⬇️
src/AtomShell/install.jl 4.87% <0.00%> (-0.13%) ⬇️
src/rpc/callbacks.jl 92.85% <0.00%> (+0.54%) ⬆️
src/content/api.jl 14.28% <0.00%> (+0.64%) ⬆️
src/content/content.jl 90.90% <0.00%> (+2.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3480c39...ed74459. Read the comment docs.

@pfitzseb pfitzseb merged commit f3d60d8 into JuliaGizmos:master Jan 12, 2021
@andreasnoack andreasnoack deleted the an/macro branch January 12, 2021 13:42
@andreasnoack
Copy link
Contributor Author

Would be great with a release if possible.

@pfitzseb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants