-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for 0.7 and add some basic tests #6
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
julia 0.6 | ||
Compat | ||
Compat 0.61.0 # for uppercasefirst | ||
Measures | ||
Colors | ||
WebIO | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,14 +2,21 @@ using CSSUtil | |
using WebIO | ||
using Compat.Test | ||
|
||
if isdefined(WebIO, :node) # TODO: remove once a new WebIO tag is in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It just got tagged, could you update this? |
||
using WebIO: node | ||
else | ||
using WebIO: Node | ||
const node = Node | ||
end | ||
|
||
@testset "hbox" begin | ||
el1 = node(:div, "Hello world!") | ||
el2 = node(:div, "Goodbye world!") | ||
box = hbox(el1, el2) | ||
@test props(box)[:style]["display"] == "flex" | ||
@test props(box)[:style]["flex-direction"] == "row" | ||
@test el1 ∈ children(box)[1] | ||
@test el2 ∈ children(box)[1] | ||
@test el1 ∈ children(box) | ||
@test el2 ∈ children(box) | ||
end | ||
|
||
@testset "vbox" begin | ||
|
@@ -18,8 +25,8 @@ end | |
box = vbox(el1, el2) | ||
@test props(box)[:style]["display"] == "flex" | ||
@test props(box)[:style]["flex-direction"] == "column" | ||
@test el1 ∈ children(box)[1] | ||
@test el2 ∈ children(box)[1] | ||
@test el1 ∈ children(box) | ||
@test el2 ∈ children(box) | ||
end | ||
|
||
@testset "hline" begin | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was necessary because after the
Node
->node
change, this would otherwise create aPersistentVector{Vector{Node}}
instead of aPersistentVector{Node}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this fixes #5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Probably worth adding a
container(xs...) = container([xs...])
method as well: this function is exported so we should try to preserve the multi-argument method.