Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of JupyterLab extension. #365

Merged
merged 7 commits into from
Dec 18, 2019

Conversation

twavv
Copy link
Member

@twavv twavv commented Dec 2, 2019

Fixes #364.

This still requires the extra step of installing nodejs in the Conda environment.

@twavv twavv force-pushed the td/fix-condajl-jupyter-installation branch 2 times, most recently from 356e5d9 to 1780d0c Compare December 2, 2019 19:33
@twavv twavv force-pushed the td/fix-condajl-jupyter-installation branch from 1780d0c to 8a42cd8 Compare December 2, 2019 19:38
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #365 into master will increase coverage by 1.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #365      +/-   ##
=========================================
+ Coverage   60.26%   62.1%   +1.83%     
=========================================
  Files          16      16              
  Lines         526     599      +73     
=========================================
+ Hits          317     372      +55     
- Misses        209     227      +18
Impacted Files Coverage Δ
src/scope.jl 65.47% <ø> (+3.13%) ⬆️
src/render.jl 27.53% <ø> (ø) ⬆️
src/providers/ijulia.jl 26.66% <0%> (-13.34%) ⬇️
src/providers/blink.jl 80% <0%> (-5.72%) ⬇️
src/asset.jl 79.24% <0%> (+1.24%) ⬆️
src/messaging.jl 22.22% <0%> (+2.22%) ⬆️
src/syntax.jl 93.58% <0%> (+2.92%) ⬆️
src/node.jl 90.74% <0%> (+3.78%) ⬆️
src/WebIO.jl 77.77% <0%> (+4.44%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8c048...857c2d8. Read the comment docs.

@twavv twavv force-pushed the td/fix-condajl-jupyter-installation branch from c79f367 to 19e153e Compare December 18, 2019 06:05
@twavv
Copy link
Member Author

twavv commented Dec 18, 2019

This branch:

  • Will prompt to install JupyterLab/NodeJS if you're installing using Conda.jl and they're not available
  • Removes a dependency on Compat.jl that's not relevant since we're lower bounded to Julia 0.7 (the compat issue was that socket stuff was moved out of Base from 0.6 to 0.7).
  • Improves some documentation around installing the extensions

@twavv twavv merged commit 99b5d78 into master Dec 18, 2019
@shashi shashi deleted the td/fix-condajl-jupyter-installation branch December 19, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot install labextension
1 participant