Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @info output #380

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Remove @info output #380

merged 1 commit into from
Jan 9, 2020

Conversation

nilshg
Copy link
Contributor

@nilshg nilshg commented Jan 7, 2020

As discussed with @travigd this message keeps popping up randomly and seems to make Juno overall more laggy (in particular in combination with TableView) so this is the nuclear option - NB I don't really know what the function does overall so this might well be a bad idea!

As discussed with @travigd this message keeps popping up randomly and seems to make Juno overall more laggy (in particular in combination with `TableView`) so this is the nuclear option - NB I don't really know what the function does overall so this might well be a bad idea!
@twavv
Copy link
Member

twavv commented Jan 7, 2020

seems to make Juno overall more laggy

I don't know what that would be about. But it's fine to delete this info message.

@nilshg
Copy link
Contributor Author

nilshg commented Jan 7, 2020

The message seems to be emitted in batches of 5-6 at a time, and it feels to me like this happens when I do showtable(df) from TableView or some plots and that it introduces some lag before the result of my command is displayed. This is just my personal impression though I haven't in any way verified or timed this.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #380 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #380     +/-   ##
========================================
+ Coverage    62.1%   62.2%   +0.1%     
========================================
  Files          16      16             
  Lines         599     598      -1     
========================================
  Hits          372     372             
+ Misses        227     226      -1
Impacted Files Coverage Δ
src/connection.jl 85.18% <ø> (+3.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7585c5...0e678a7. Read the comment docs.

@shashi shashi merged commit f156ddd into JuliaGizmos:master Jan 9, 2020
@nilshg nilshg deleted the patch-1 branch February 10, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants