Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Observables" to "0.5" #488

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 1, 2022

This pull request changes the compat entry for the Observables package from 0.3, 0.4 to 0.3, 0.4, 0.5.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@babaq
Copy link

babaq commented May 12, 2022

@pfitzseb could it be merged now, just found that the latest GLMakie needs Observable v0.5.

@musm
Copy link

musm commented May 18, 2022

bump

@musm
Copy link

musm commented May 19, 2022

@SimonDanisch

@pfitzseb
Copy link
Member

Did someone check that this actually works?

@musm
Copy link

musm commented May 19, 2022

I've only gone as far as checking the test suite and all the tests pass with these changes.

@pfitzseb pfitzseb merged commit 82e1c89 into master May 19, 2022
@musm
Copy link

musm commented May 19, 2022

Any chance we could also tag the latest release?

@SimonDanisch SimonDanisch deleted the compathelper/new_version/2022-05-01-01-25-07-837-2623975958 branch May 19, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants