This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep. |
CI seems to be unhappy. |
Seems like an unrelated failure? |
Only on Mac. Seems to be unrelated? |
Some Mac users have strong oppinions on that... I'm not an expert on this, but could it be another Homebrew hiccup?
|
it worked a few weeks ago, ref https://travis-ci.org/JuliaGraphics/Gtk.jl/builds/142129851 - but Homebrew.jl has gone through some overhauls recently |
@tkelman: So, is it ok to ignore this for the current PR? The fix looks ok. |
@lobingera my point was that if it only fails on mac then it is likely not the PR's fault since the change should be OS agnostic. |
@KristofferC I agree. But if building gtk3+ on travis creates a problem, another issue should be opened. |
Please do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks correct @stevengj?
ref JuliaLang/julia#17393 (comment)