Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

fix broken syntax on 0.5 #245

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Conversation

KristofferC
Copy link
Contributor

@stevengj
Copy link

Yep.

@tknopp
Copy link
Collaborator

tknopp commented Jul 21, 2016

CI seems to be unhappy.

@stevengj
Copy link

Seems like an unrelated failure?

@KristofferC
Copy link
Contributor Author

Only on Mac. Seems to be unrelated?

@lobingera
Copy link
Contributor

Only on Mac.

Some Mac users have strong oppinions on that...

I'm not an expert on this, but could it be another Homebrew hiccup?

> (<unknown>:50507): GdkPixbuf-WARNING **: Cannot open pixbuf loader module file '/Users/travis/.julia/v0.4/Homebrew/deps/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache': No such file or directory

This likely means that your installation is broken.

Try running the command

  gdk-pixbuf-query-loaders > /Users/travis/.julia/v0.4/Homebrew/deps/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache

to make things work again for the time being.

@tknopp
Copy link
Collaborator

tknopp commented Jul 21, 2016

@tkelman has activated CI on mac in #213.
What should we for this PR? Ignore CI on Mac?

@tkelman
Copy link
Contributor

tkelman commented Jul 21, 2016

it worked a few weeks ago, ref https://travis-ci.org/JuliaGraphics/Gtk.jl/builds/142129851 - but Homebrew.jl has gone through some overhauls recently

@tknopp
Copy link
Collaborator

tknopp commented Jul 21, 2016

@tkelman: So, is it ok to ignore this for the current PR? The fix looks ok.

@KristofferC
Copy link
Contributor Author

KristofferC commented Jul 21, 2016

@lobingera my point was that if it only fails on mac then it is likely not the PR's fault since the change should be OS agnostic.

@lobingera
Copy link
Contributor

@KristofferC I agree. But if building gtk3+ on travis creates a problem, another issue should be opened.

@tknopp tknopp merged commit f284337 into JuliaGraphics:master Jul 21, 2016
@KristofferC KristofferC deleted the patch-1 branch July 21, 2016 14:09
@KristofferC
Copy link
Contributor Author

Please do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants