-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better browsing #199
Better browsing #199
Conversation
I had to adjust quite a few tests since b = rootfile["some/path"] now needs an explicit call to b = LazyBranch(rootfile, "some/path") (btw. TAB-completion would be awesome 😆 ) |
Codecov ReportBase: 90.33% // Head: 90.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 90.33% 90.00% -0.34%
==========================================
Files 18 18
Lines 2091 2100 +9
==========================================
+ Hits 1889 1890 +1
- Misses 202 210 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@tamasgal yeah I think it's fine. So:
thanks for this! |
0fead00
to
41676cc
Compare
Alright @Moelf from my side it's done. Can you have a look? I put a notice in the README, I think we can leave it there for a while, at least until v1.0 😉 |
Thanks! I'll go ahead with the release then |
This will break a few things since
f["what/ever"]
will now always return the object which sits at that "position" but the navigation is much easier.Before this PR,
UnROOT
choked on branches which could not be interpreted so that the user's only option to explore the structure was to use.fBranches
etc. and dig into ROOT internals.Now, if a
TTree
orTBranchElement
is returned bygetindex()
, the branches are listed: