Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in KomaMRI.jl #143

Closed
cncastillo opened this issue Jan 5, 2023 · 2 comments
Closed

Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in KomaMRI.jl #143

cncastillo opened this issue Jan 5, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@cncastillo
Copy link
Member

This causes an error when compiling Koma.
@cncastillo cncastillo changed the title Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in Jan 5, 2023
@cncastillo cncastillo changed the title Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in Blink v0.12.6 removed functions AtomShell.isinstalled() and AtomShell.install() used in KomaMRI.jl Jan 5, 2023
cncastillo added a commit that referenced this issue Jan 5, 2023
@cncastillo
Blink rm func AtomShell.isinstalled() ... #143
9524768
@cncastillo
Copy link
Member Author

cncastillo commented Jan 5, 2023 •
edited
Loading

@beorostica Can you check if this commit fixes the problem? Or is it better to also change the compat of Blink to 0.12.6?

Related: JuliaGizmos/Blink.jl@c050d0b, JuliaGizmos/Blink.jl#296

@cncastillo cncastillo added the help wanted Extra attention is needed label Jan 5, 2023
@beorostica
Copy link
Contributor

I tested the project with the new commit in a fresh installation with Julia 1.8.4. The UI is working without a any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cncastillo @beorostica