-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KomaMRI v0.7.4: Bug fixes and minor features #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
===========================================
+ Coverage 48.91% 92.45% +43.54%
===========================================
Files 35 39 +4
Lines 2067 2135 +68
===========================================
+ Hits 1011 1974 +963
+ Misses 1056 161 -895
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Plot Eddy current spectra, and colored sim blocks in plot_seq
is_X_on now considers 1:end-1.
Modified how blocks are handled (get_sim_ranges).
new sim block plotting, changed how `t` is handled.
This was
linked to
issues
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I have changed some parts of the simulation method to be able to sample the magnetization in an RF Bloch. Also, I fixed bugs #161 #162 #85 #88 by modifying the TimeStepCalculation.jl
get_variable_times
. Finally, I added some extra features, as now you can plot the eddy currents and the MC2 of a sequence, and a new BlochDict method that showcases how you can generate custom outputs and create new simulation methods without the need of modifying the source code of KomaMRICore.KomaMRI -> 0.7.4
KomaCore -> 0.7.5
KomaPlots -> 0.7.5