Convert to Int before indexing with Char in Array #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression fix from JuliaLang/julia#8816 Fixes #84
|
LGTM. |
|
+1. Can't even tag fixes to packages broken by 0.4 because this was broken also :) |
ivarne
added a commit
that referenced
this pull request
Oct 28, 2014
Convert to Int before indexing with Char in Array
|
Can someone test and tag a new version? It will also include 888e6dd, but that doesn't look like a problem for me. |
|
Tested and tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression fix from JuliaLang/julia#8816
Fixes #84
This seems like an obvious fix to me. We could reenable indexing with
Char, but it seems more clear to convert manually when we need it in cases like this.