Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForwardDiff dependency #13

Merged
merged 1 commit into from
May 18, 2017
Merged

Remove ForwardDiff dependency #13

merged 1 commit into from
May 18, 2017

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Apr 23, 2017

These were ambiguous on 0.4. They don't seem to be required any more, but see IntervalRootFinding tests.

@codecov-io
Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #13 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
+ Coverage   92.14%   92.34%   +0.2%     
=========================================
  Files          22       22             
  Lines         917      915      -2     
=========================================
  Hits          845      845             
+ Misses         72       70      -2
Impacted Files Coverage Δ
src/intervals/conversion.jl 69.56% <ø> (+2.89%) ⬆️
src/decorations/intervals.jl 89.47% <ø> (+2.29%) ⬆️
src/IntervalArithmetic.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bb130...766451f. Read the comment docs.

@dpsanders dpsanders force-pushed the remove_forwarddiff branch from f54c1e8 to 766451f Compare May 13, 2017 00:31
@lbenet
Copy link
Member

lbenet commented May 18, 2017

I think this is ready to be merged; shall I? I think it is convenient to have it merged before tagging a new minor version.

@dpsanders
Copy link
Member Author

Yes please!

@lbenet lbenet merged commit 33e89f3 into master May 18, 2017
@lbenet
Copy link
Member

lbenet commented May 18, 2017

Done!

@lbenet lbenet deleted the remove_forwarddiff branch May 18, 2017 20:31
@dpsanders
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants