Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor for n-dimensional IntervalBox #79

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Conversation

dpsanders
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #79 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +<.01%     
==========================================
  Files          21       21              
  Lines         980      981       +1     
==========================================
+ Hits          894      895       +1     
  Misses         86       86
Impacted Files Coverage Δ
src/multidim/intervalbox.jl 88.23% <100%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12463f1...f130c1f. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.009%) to 91.233% when pulling 151d80e on intervalbox_n_dim into 12463f1 on master.

@lbenet
Copy link
Member

lbenet commented Jun 30, 2017

LGTM. Is this ready to be merged?

@dpsanders
Copy link
Member Author

Yes, this is ready to me merged!

@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Coverage increased (+1.1%) to 92.324% when pulling f130c1f on intervalbox_n_dim into 12463f1 on master.

@lbenet
Copy link
Member

lbenet commented Aug 3, 2017

Great! Thanks! I'm merging!

@lbenet lbenet merged commit 14ef2a2 into master Aug 3, 2017
@lbenet
Copy link
Member

lbenet commented Aug 3, 2017

Ups... I just noticed that travis tests did not pass for Julia nightly...

@dpsanders
Copy link
Member Author

I have a fix for the issue on nightly here:

#88

@lbenet
Copy link
Member

lbenet commented Aug 3, 2017

#88 is already merged, so why didn't the tests pass?

@dpsanders
Copy link
Member Author

#88 is open, it hasn't been merged yet?

@lbenet
Copy link
Member

lbenet commented Aug 4, 2017

You are right, sorry for the noise. I hope I'll find some time today (or during the weekend) to take a look on this.

@dpsanders dpsanders deleted the intervalbox_n_dim branch April 9, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants