Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move general methods of IntervalBox to IntervalArithmetic #83

Merged
merged 8 commits into from
Jul 17, 2018
Merged

Move general methods of IntervalBox to IntervalArithmetic #83

merged 8 commits into from
Jul 17, 2018

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Jun 19, 2018

Fixes #78

@lbenet lbenet mentioned this pull request Jun 22, 2018
Merged
@lbenet
Copy link
Member Author

lbenet commented Jun 22, 2018

Tests require the corresponding changes in IntervalArithmetics (and probably a tagged version) to pass.

@lbenet
Copy link
Member Author

lbenet commented Jun 24, 2018

@dpsanders Shall I go ahead and merge this? JuliaIntervals/IntervalArithmetic.jl#160 has been merged.

This was referenced Jun 26, 2018
Closed
Closed
lbenet referenced this pull request in JuliaIntervals/IntervalArithmetic.jl Jun 29, 2018
@lbenet
Add methods for IntervalBox previously in IntervalRootFinding (#160)
37f126e 
* Add methods for IntervalBox previously in IntervalRootFinding

* Remove a reference to IntervalRootFinding, and fix complex interval test

* Implement suggestions of the review

* Incorporate a missing suggestion of the review
@eeshan9815 eeshan9815 mentioned this pull request Jun 30, 2018
Closed
@dpsanders dpsanders changed the title Move general methods of IntervalBox to IntervalArithmetics Move general methods of IntervalBox to IntervalArithmetic Jul 10, 2018
@eeshan9815 eeshan9815 mentioned this pull request Jul 17, 2018
Merged
@codecov-io
Copy link

codecov-io commented Jul 17, 2018 •
edited
Loading

Codecov Report

Merging #83 into master will increase coverage by 2.12%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   56.14%   58.26%   +2.12%     
==========================================
  Files          10        9       -1     
  Lines         431      393      -38     
==========================================
- Hits          242      229      -13     
+ Misses        189      164      -25
Impacted Files Coverage Δ
src/newton.jl 0% <ø> (ø) ⬆️
src/krawczyk.jl 0% <ø> (ø) ⬆️
src/contractors.jl 90% <100%> (-0.48%) ⬇️
src/roots.jl 88.13% <100%> (+2.19%) ⬆️
src/IntervalRootFinding.jl 4.65% <100%> (+2.61%) ⬆️
src/complex.jl 83.33% <66.66%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6491d43...3bd5d92. Read the comment docs.

@dpsanders dpsanders merged commit 9f212fb into master Jul 17, 2018
@dpsanders
Copy link
Member

Thanks @lbenet !

@lbenet lbenet deleted the lb/iss78 branch February 14, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbenet @codecov-io @dpsanders