Skip to content

Commit

Permalink
Add some comments linking to the PR and the bug report
Browse files Browse the repository at this point in the history
Thus, future readers of the source code will understand why we use this naming convention.

[Applies suggestions from code review.]
  • Loading branch information
DilumAluthge authored Oct 15, 2024
1 parent a8ab5c9 commit 9387406
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/PackageCompiler.jl
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ function create_fresh_base_sysimage(stdlibs::Vector{String}; cpu_target::String,
base_dir = dirname(sysimg_source_path)
tmp_corecompiler_ji = joinpath(tmp, "corecompiler.ji")
tmp_sys_o = joinpath(tmp, "sys-o.a")
# This naming convention (`sys-o.a`) is necessary to make the sysimage
# work on macOS.
# Bug report: https://github.com/JuliaLang/PackageCompiler.jl/issues/738
# PR: https://github.com/JuliaLang/PackageCompiler.jl/pull/930
tmp_sys_sl = joinpath(tmp, "sys." * Libdl.dlext)

compiler_source_path = joinpath(base_dir, "compiler", "compiler.jl")
Expand Down Expand Up @@ -640,6 +644,10 @@ function create_sysimage(packages::Union{Nothing, Symbol, Vector{String}, Vector

# Create the sysimage
object_file = tempname() * "-o.a"
# This naming convention (`-o.a`) is necessary to make the sysimage
# work on macOS.
# Bug report: https://github.com/JuliaLang/PackageCompiler.jl/issues/738
# PR: https://github.com/JuliaLang/PackageCompiler.jl/pull/930

create_sysimg_object_file(object_file, packages, packages_sysimg;
project,
Expand Down

0 comments on commit 9387406

Please sign in to comment.