Bump julia [compat] to 1.10 (and drop support for 1.6 through 1.9)
#1005
Conversation
|
Dropping some old CI jobs seems okay. Is it necessary to bump the Julia compat? We could just leave the Julia compat as is, and if new PackageCompiler releases continue to work on old Julia releases, that seems fine, right? I think it'd be nice to at least keep compatibility with 1.6 for now, since it was the LTS for a long time, and there are likely still people using it. |
test/runtests.jl
Outdated
| @@ -117,7 +105,7 @@ end | |||
| @info "starting: create_app testset" incremental filter | |||
| tmp_app_source_dir = joinpath(tmp, "MyApp") | |||
| cp(app_source_dir, tmp_app_source_dir) | |||
| if is_gha_ci && (is_julia_1_6 || is_julia_1_9) | |||
| if is_gha_ci | |||
There was a problem hiding this comment.
You'd want to remove this entire if-end block.
|
People can still use PackageCompiler with 1.6. I think getting rid of a bunch of old version checks to simplify the code is worth it. For example I think PackageCompiler.jl/src/PackageCompiler.jl Line 1169 in 8d6fce0 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 87.73% 86.19% -1.54%
==========================================
Files 3 3
Lines 799 797 -2
==========================================
- Hits 701 687 -14
- Misses 98 110 +12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
DilumAluthge
changed the title
DilumAluthge
changed the title
julia compat to 1.10 (and drop support for 1.6 through 1.9)
There was a problem hiding this comment.
Personally, I don't think that the relatively minor (IMO) code simplifications are worth dropping support for 1.6. My thinking is that 1.6 was the LTS for a long time, so people are probably going to keep using 1.6 for a while, and it would be nice for those users to keep getting PackageCompiler improvements.
That all being said, I don't feel particularly strongly about this, so I won't stand in the way.
We should make the next PackageCompiler release 2.2.0. That way, if we do end up needing to backport a bug fix, we can do so in the 2.1.x release series.
DilumAluthge
changed the title
julia compat to 1.10 (and drop support for 1.6 through 1.9)julia [compat] to 1.10 (and drop support for 1.6 through 1.9)
The CI matrix has ballooned up to a ridiculous number of combinations at this point. First step to reduce it seems to be to stop supporting and testing unsupported julia releases.