Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" #983

Merged
merged 10 commits into from
Oct 20, 2024

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 20, 2024

In my recent CI experiments, I've discovered some bugs that only occur in one branch of incremental={true,false}. So I think we should try to exercise both of those branches in CI, even if we are in "slow CI".

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Oct 20, 2024

I did a bit of Git archeology. As far as I can tell, the is_slow_ci flag was introduced before we had Apple Silicon. I wonder if we maybe had Linux aarch64 CI back then, and that's what the is_slow_ci flag was meant to cover.

AFAICT, the Apple Silicon GitHub Actions CI GitHub-hosted runners on this repo seem to run the CI jobs pretty quickly.

So I don't think Apple Silicon should count as "slow CI".

@DilumAluthge DilumAluthge changed the title CI: Test both incremental={true,false} on "slow CI" CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" Oct 20, 2024
@DilumAluthge DilumAluthge changed the title CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" CI: Stop considering Apple Silicon macOS as "slow CI" Oct 20, 2024
@DilumAluthge DilumAluthge changed the title CI: Stop considering Apple Silicon macOS as "slow CI" CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" Oct 20, 2024
@DilumAluthge DilumAluthge changed the title CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" Oct 20, 2024
Base automatically changed from dpa/nightly to master October 20, 2024 10:41
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (f5eba5f) to head (14f260e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files           3        3           
  Lines         823      823           
=======================================
  Hits          696      696           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge merged commit cdde346 into master Oct 20, 2024
44 checks passed
@DilumAluthge DilumAluthge deleted the dpa/slow-ci branch October 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant