-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test both incremental={true,false}
on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI"
#983
Conversation
…e it does `incremental=false`)
I did a bit of Git archeology. As far as I can tell, the AFAICT, the Apple Silicon GitHub Actions CI GitHub-hosted runners on this repo seem to run the CI jobs pretty quickly. So I don't think Apple Silicon should count as "slow CI". |
incremental={true,false}
on "slow CI"incremental={true,false}
on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI"
incremental={true,false}
on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI"incremental={true,false}
on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 3 3
Lines 823 823
=======================================
Hits 696 696
Misses 127 127 ☔ View full report in Codecov by Sentry. |
In my recent CI experiments, I've discovered some bugs that only occur in one branch of
incremental={true,false}
. So I think we should try to exercise both of those branches in CI, even if we are in "slow CI".