prune manifest after the set of some deps have been "demoted" to weakdeps #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not 100% satisfactory though because we download the packages before this step and IIUC it means we would download Enzyme in this case and only then prune the manifest to remove it. So perhaps we need to do this before we have downloaded anything. (The reason Enzyme ends up here at all is because with the tiered resolver we first try to resolve things with all non-input packages having identical versions, so Enzyme being in the manifest then ends up as an output from the resolver). |
|
At least this is better than status quo. |
6 tasks
KristofferC
added a commit
that referenced
this pull request
May 9, 2024
KristofferC
added a commit
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the manifest pruning issue in #3863.
Before we run this fixup code we do not know which deps are weak and not (all are considered normal deps). Or well, we kind of know but we don't have the information easily retrievable. Manifest pruning before this stage will not prune orphan entries which are weak deps of some package which is why in #3863 Enzyme was not pruned away (it is a weak dep of DiffEqBase).
Solve this by just pruning after we have categorized things into weak/normal deps.