Skip to content

Commit

Permalink
Revert "Restrict binary ops for Diagonal and Symmetric to Number elty…
Browse files Browse the repository at this point in the history
…pes (#55251)"

This reverts commit 30573be.
  • Loading branch information
KristofferC committed Jan 2, 2025
1 parent 651f931 commit 2872bc3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
4 changes: 2 additions & 2 deletions stdlib/LinearAlgebra/src/diagonal.jl
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,10 @@ end
(-)(Da::Diagonal, Db::Diagonal) = Diagonal(Da.diag - Db.diag)

for f in (:+, :-)
@eval function $f(D::Diagonal{<:Number}, S::Symmetric)
@eval function $f(D::Diagonal, S::Symmetric)
return Symmetric($f(D, S.data), sym_uplo(S.uplo))
end
@eval function $f(S::Symmetric, D::Diagonal{<:Number})
@eval function $f(S::Symmetric, D::Diagonal)
return Symmetric($f(S.data, D), sym_uplo(S.uplo))
end
@eval function $f(D::Diagonal{<:Real}, H::Hermitian)
Expand Down
12 changes: 0 additions & 12 deletions stdlib/LinearAlgebra/test/diagonal.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1193,16 +1193,4 @@ end
end
end

@testset "+/- with block Symmetric/Hermitian" begin
for p in ([1 2; 3 4], [1 2+im; 2-im 4+2im])
m = SizedArrays.SizedArray{(2,2)}(p)
D = Diagonal(fill(m, 2))
for T in (Symmetric, Hermitian)
S = T(fill(m, 2, 2))
@test D + S == Array(D) + Array(S)
@test S + D == Array(S) + Array(D)
end
end
end

end # module TestDiagonal

0 comments on commit 2872bc3

Please sign in to comment.