make Type{Union{}} ismutationfree (#48417)

JuliaLang · Jan 28, 2023 · f6f6b1c · f6f6b1c · nanosoldier · Jan 28, 2023
1 parent 8b9da8d
commit f6f6b1c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/jltypes.c b/src/jltypes.c
@@ -2204,6 +2204,7 @@ void jl_init_types(void) JL_GC_DISABLED
     ((jl_datatype_t*)jl_type_type)->cached_by_hash = 0;
     jl_type_typename->wrapper = jl_new_struct(jl_unionall_type, tttvar, (jl_value_t*)jl_type_type);
     jl_type_type = (jl_unionall_t*)jl_type_typename->wrapper;
+    ((jl_datatype_t*)jl_type_type->body)->ismutationfree = 1;
 
     jl_typeofbottom_type->super = jl_wrap_Type(jl_bottom_type);
 
@@ -2807,7 +2808,6 @@ void jl_init_types(void) JL_GC_DISABLED
     jl_symbol_type->ismutationfree = jl_symbol_type->isidentityfree = 1;
     jl_simplevector_type->ismutationfree = jl_simplevector_type->isidentityfree = 1;
     jl_datatype_type->ismutationfree = 1;
-    ((jl_datatype_t*)jl_type_type->body)->ismutationfree = 1;
 
     // Technically not ismutationfree, but there's a separate system to deal
     // with mutations for global state.

diff --git a/test/compiler/effects.jl b/test/compiler/effects.jl
@@ -740,3 +740,6 @@ end |> !Core.Compiler.is_consistent
     ImmutRef(x) = $(Expr(:new, :(ImmutRef{typeof(x)}), :x))
 end
 @test Core.Compiler.is_foldable(Base.infer_effects(ImmutRef, Tuple{Any}))
+
+@test Base.ismutationfree(Type{Union{}})
+@test Core.Compiler.is_total(Base.infer_effects(typejoin, ()))