Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string interpolation and escaping bug #100

Closed
StefanKarpinski opened this issue Jul 8, 2011 · 8 comments
Closed

string interpolation and escaping bug #100

StefanKarpinski opened this issue Jul 8, 2011 · 8 comments
Assignees
@StefanKarpinski
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@StefanKarpinski
Copy link
Member 

julia> println("\\ $('x')")
 x

julia> println("\\ x")
\ x
@ghost ghost assigned StefanKarpinski Jul 8, 2011
@JeffBezanson
Copy link
Member

Might be my fault. In the parser I unescape \ and " in strings that will be passed to macros. I don't have any idea why I'm doing that.

@StefanKarpinski
Copy link
Member Author

Other symptoms:

julia> "\\\\"
"\\\\"

julia> S"\\\\"
"\\"


julia> "\\\""
"\\\""

julia> S"\\\""
"\""

@StefanKarpinski
Copy link
Member Author

I think that's what's going on: you should turn \" into " but not turn \\ into \. Leaving \" as-is is harmless w.r.t. standard escaping rules, however, since \" just decodes as ". This is sort of mind-numbing stuff. Not quite sure what the right course of action is.

@StefanKarpinski
Copy link
Member Author

Btw, I'm not sure about this at all. I'm still mulling over what the right thing to do here is.

JeffBezanson added a commit that referenced this issue Jul 9, 2011
@JeffBezanson
fixing issue #100
d443299
@JeffBezanson
Copy link
Member

I changed the parser behavior and it seems to work, and all tests still pass. I can't imagine why the behavior I had before was the right thing. Unless we can figure that out, we seem to be ok now.

@JeffBezanson
Copy link
Member

Ah, there is the case of L"\"". I guess that should be a string of one quote character?
Then there is kind of a strange situation where you can't make a string of a single \ using L syntax. L"\" escapes the quote and is incomplete input, and L"\\" is two backslashes.

JeffBezanson added a commit that referenced this issue Jul 9, 2011
@JeffBezanson
trying again on issue #100. unescape only " for macro arguments.
40cf0d8
@StefanKarpinski
Copy link
Member Author

I'm kind of thinking that the behavior of d443299 is the best. True, you can't use L" to make just " or \, but I think that may be unavoidable. The simplest behavior to understand seems to be that L" always makes a string literal that's exactly what's between the opening and closing quotes — and \" is a way of indicating that an intervening " is not the closing one. I'm pretty sure you can't avoid at least having your escape character \ be inexpressible in L" strings — this is why escaping exists. The only question is whether we want the same to apply to " or not. The difference between \ and " is that \ will be the escape character no matter what quote syntax exists, whereas " is specific to this quoting form. If we implement L""" then " by itself won't be a special character anymore. However, I still think the policy of passing the literal contents through may be best.

JeffBezanson added a commit that referenced this issue Jul 9, 2011
@JeffBezanson
Revert "Revert "fixing issue #100""
7031bf6 
This reverts commit 793b9a5.

Conflicts:

	src/julia-parser.scm
@JeffBezanson
Copy link
Member

OK finally settled :)

This was referenced Dec 30, 2020
Closed
Closed
fredrikekre added a commit that referenced this issue Feb 26, 2021
@fredrikekre
Update Downloads.jl to fix download hanging, fixes #39789.
ae9111e 
$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix #99) (#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix #91) (#100)
KristofferC pushed a commit that referenced this issue Feb 26, 2021
@fredrikekre
Update Downloads.jl to fix download hanging, fixes #39789. (#39833)
fb500b0 
$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix #99) (#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix #91) (#100)
KristofferC pushed a commit that referenced this issue Mar 2, 2021
@fredrikekre @KristofferC
Update Downloads.jl to fix download hanging, fixes #39789. (#39833)
4161f4a 
$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix #99) (#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix #91) (#100)

(cherry picked from commit fb500b0)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@fredrikekre @ElOceanografo
Update Downloads.jl to fix download hanging, fixes JuliaLang#39789. (J…
ec3ac37 
…uliaLang#39833)

$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix JuliaLang#99) (JuliaLang#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix JuliaLang#91) (JuliaLang#100)
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@fredrikekre @antoine-levitt
Update Downloads.jl to fix download hanging, fixes JuliaLang#39789. (J…
df39442 
…uliaLang#39833)

$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix JuliaLang#99) (JuliaLang#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix JuliaLang#91) (JuliaLang#100)
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@fredrikekre @staticfloat
Update Downloads.jl to fix download hanging, fixes #39789. (#39833)
d1f681c 
$ git log --pretty=oneline --abbrev=commit 2b4bed9..6bb8306
6bb83068bd796c4890baaeb39628ff79a4979374 Stop the grace timer iff adding first handle (fix #99) (#102)
af6864d8872247faf2a402d6b2baca5cb74ab96e fix ssh_key_pass bug (fix #91) (#100)

(cherry picked from commit fb500b0)
Keno pushed a commit that referenced this issue Oct 9, 2023
@timholy
Merge pull request #100 from vtjnash/jn/patch-1
c0e481d 
avoid some internal methods and invalid objects
udesou pushed a commit to udesou/julia that referenced this issue Nov 22, 2023
@d-netto
missing gc_mark_push_remset in obj32 (JuliaLang#100)
92be98f
inkydragon pushed a commit that referenced this issue Dec 15, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the SHA stdlib from aaf2df6 to 8fa221d (#56834)
e9c007f 
Stdlib: SHA
URL: https://github.com/JuliaCrypto/SHA.jl.git
Stdlib branch: master
Julia branch: master
Old commit: aaf2df6
New commit: 8fa221d
Julia version: 1.12.0-DEV
SHA version: 0.7.0(Does not match)
Bump invoked by: @inkydragon
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaCrypto/SHA.jl@aaf2df6...8fa221d

```
$ git log --oneline aaf2df6..8fa221d
8fa221d ci: update doctest config (#120)
346b359 ci: Update ci config (#115)
aba9014 Fix type mismatch for `shake/digest!` and setup x86 ci (#117)
0b76d04 Merge pull request #114 from JuliaCrypto/dependabot/github_actions/codecov/codecov-action-5
5094d9d Update .github/workflows/CI.yml
45596b1 Bump codecov/codecov-action from 4 to 5
230ab51 test: remove outdate tests (#113)
7f25aa8 rm: Duplicated const alias (#111)
aa72f73 [SHA3] Fix padding special-case (#108)
3a01401 Delete Manifest.toml (#109)
da351bb Remvoe all getproperty funcs (#99)
4eee84f Bump codecov/codecov-action from 3 to 4 (#104)
15f7dbc Bump codecov/codecov-action from 1 to 3 (#102)
860e6b9 Bump actions/checkout from 2 to 4 (#103)
8e5f0ea Add dependabot to auto update github actions (#100)
4ab324c Merge pull request #98 from fork4jl/sha512-t
a658829 SHA-512: add ref to NIST standard
11a4c73 Apply suggestions from code review
969f867 Merge pull request #97 from fingolfin/mh/Vector
b1401fb SHA-512: add NIST test
4d7091b SHA-512: add to docs
09fef9a SHA-512: test SHA-512/224, SHA-512/256
7201b74 SHA-512: impl SHA-512/224, SHA-512/256
4ab85ad Array -> Vector
8ef91b6 fixed bug in padding for shake, addes testcases for full code coverage (#95)
88e1c83 Remove non-existent property (#75)
068f85d shake128,shake256: fixed typo in export declarations (#93)
176baaa SHA3 xof shake128 and shake256  (#92)
e1af7dd Hardcode doc edit backlink
```

Co-authored-by: Dilum Aluthge <[email protected]>
DilumAluthge added a commit that referenced this issue Dec 17, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the Distributed stdlib from 6c7cdb5 to c613685 (#56825)
2ed1a41 
Stdlib: Distributed
URL: https://github.com/JuliaLang/Distributed.jl
Stdlib branch: master
Julia branch: master
Old commit: 6c7cdb5
New commit: c613685
Julia version: 1.12.0-DEV
Distributed version: 1.11.0(Does not match)
Bump invoked by: @DilumAluthge
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Distributed.jl@6c7cdb5...c613685

```
$ git log --oneline 6c7cdb5..c613685
c613685 Merge pull request #116 from JuliaLang/ci-caching
20e2ce7 Use julia-actions/cache in CI
9c5d73a Merge pull request #112 from JuliaLang/dependabot/github_actions/codecov/codecov-action-5
ed12496 Merge pull request #107 from JamesWrigley/remotechannel-empty
010828a Update .github/workflows/ci.yml
11451a8 Bump codecov/codecov-action from 4 to 5
8b5983b Merge branch 'master' into remotechannel-empty
729ba6a Fix docstring of `@everywhere` (#110)
af89e6c Adding better docs to exeflags kwarg (#108)
8537424 Implement Base.isempty(::RemoteChannel)
6a0383b Add a wait(::[Abstract]WorkerPool) (#106)
1cd2677 Bump codecov/codecov-action from 1 to 4 (#96)
cde4078 Bump actions/cache from 1 to 4 (#98)
6c8245a Bump julia-actions/setup-julia from 1 to 2 (#97)
1ffaac8 Bump actions/checkout from 2 to 4 (#99)
8e3f849 Fix RemoteChannel iterator interface (#100)
f4aaf1b Fix markdown errors in README.md (#95)
2017da9 Merge pull request #103 from JuliaLang/sf/sigquit_instead
07389dd Use `SIGQUIT` instead of `SIGTERM`
```

Co-authored-by: Dilum Aluthge <[email protected]>
stevengj pushed a commit that referenced this issue Jan 2, 2025
@DilumAluthgeBot @DilumAluthge @stevengj
🤖 [master] Bump the SHA stdlib from aaf2df6 to 8fa221d (#56834)
19e7246 
Stdlib: SHA
URL: https://github.com/JuliaCrypto/SHA.jl.git
Stdlib branch: master
Julia branch: master
Old commit: aaf2df6
New commit: 8fa221d
Julia version: 1.12.0-DEV
SHA version: 0.7.0(Does not match)
Bump invoked by: @inkydragon
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaCrypto/SHA.jl@aaf2df6...8fa221d

```
$ git log --oneline aaf2df6..8fa221d
8fa221d ci: update doctest config (#120)
346b359 ci: Update ci config (#115)
aba9014 Fix type mismatch for `shake/digest!` and setup x86 ci (#117)
0b76d04 Merge pull request #114 from JuliaCrypto/dependabot/github_actions/codecov/codecov-action-5
5094d9d Update .github/workflows/CI.yml
45596b1 Bump codecov/codecov-action from 4 to 5
230ab51 test: remove outdate tests (#113)
7f25aa8 rm: Duplicated const alias (#111)
aa72f73 [SHA3] Fix padding special-case (#108)
3a01401 Delete Manifest.toml (#109)
da351bb Remvoe all getproperty funcs (#99)
4eee84f Bump codecov/codecov-action from 3 to 4 (#104)
15f7dbc Bump codecov/codecov-action from 1 to 3 (#102)
860e6b9 Bump actions/checkout from 2 to 4 (#103)
8e5f0ea Add dependabot to auto update github actions (#100)
4ab324c Merge pull request #98 from fork4jl/sha512-t
a658829 SHA-512: add ref to NIST standard
11a4c73 Apply suggestions from code review
969f867 Merge pull request #97 from fingolfin/mh/Vector
b1401fb SHA-512: add NIST test
4d7091b SHA-512: add to docs
09fef9a SHA-512: test SHA-512/224, SHA-512/256
7201b74 SHA-512: impl SHA-512/224, SHA-512/256
4ab85ad Array -> Vector
8ef91b6 fixed bug in padding for shake, addes testcases for full code coverage (#95)
88e1c83 Remove non-existent property (#75)
068f85d shake128,shake256: fixed typo in export declarations (#93)
176baaa SHA3 xof shake128 and shake256  (#92)
e1af7dd Hardcode doc edit backlink
```

Co-authored-by: Dilum Aluthge <[email protected]>
stevengj pushed a commit that referenced this issue Jan 2, 2025
@DilumAluthgeBot @DilumAluthge @stevengj
🤖 [master] Bump the Distributed stdlib from 6c7cdb5 to c613685 (#56825)
79fd0cc 
Stdlib: Distributed
URL: https://github.com/JuliaLang/Distributed.jl
Stdlib branch: master
Julia branch: master
Old commit: 6c7cdb5
New commit: c613685
Julia version: 1.12.0-DEV
Distributed version: 1.11.0(Does not match)
Bump invoked by: @DilumAluthge
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Distributed.jl@6c7cdb5...c613685

```
$ git log --oneline 6c7cdb5..c613685
c613685 Merge pull request #116 from JuliaLang/ci-caching
20e2ce7 Use julia-actions/cache in CI
9c5d73a Merge pull request #112 from JuliaLang/dependabot/github_actions/codecov/codecov-action-5
ed12496 Merge pull request #107 from JamesWrigley/remotechannel-empty
010828a Update .github/workflows/ci.yml
11451a8 Bump codecov/codecov-action from 4 to 5
8b5983b Merge branch 'master' into remotechannel-empty
729ba6a Fix docstring of `@everywhere` (#110)
af89e6c Adding better docs to exeflags kwarg (#108)
8537424 Implement Base.isempty(::RemoteChannel)
6a0383b Add a wait(::[Abstract]WorkerPool) (#106)
1cd2677 Bump codecov/codecov-action from 1 to 4 (#96)
cde4078 Bump actions/cache from 1 to 4 (#98)
6c8245a Bump julia-actions/setup-julia from 1 to 2 (#97)
1ffaac8 Bump actions/checkout from 2 to 4 (#99)
8e3f849 Fix RemoteChannel iterator interface (#100)
f4aaf1b Fix markdown errors in README.md (#95)
2017da9 Merge pull request #103 from JuliaLang/sf/sigquit_instead
07389dd Use `SIGQUIT` instead of `SIGTERM`
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanKarpinski StefanKarpinski

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanKarpinski @JeffBezanson