Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction of setenv and cmd interpolation #24353

Closed
Keno opened this issue Oct 26, 2017 · 4 comments · Fixed by #31768
Closed

Interaction of setenv and cmd interpolation #24353

Keno opened this issue Oct 26, 2017 · 4 comments · Fixed by #31768
Labels
minor change Marginal behavior change acceptable for a minor release

Comments

@Keno
Copy link
Member

Keno commented Oct 26, 2017

I think interpolating a cmd that had its env set should either raise an error or propagate the environment. Current behavior:

julia> c = setenv(`x`, "A"=>true)
setenv(`x`,String["A=true"])

julia> `$c`
`x`
@Keno Keno added the triage This should be discussed on a triage call label Sep 4, 2018
@Keno
Copy link
Member Author

Keno commented Sep 4, 2018

Just ran into this again. We missed 1.0 of course, but marking for triage on what to do here.

@Keno
Copy link
Member Author

Keno commented Sep 4, 2018

Quick discussion with @JeffBezanson, one possible solution may be to allow interpolation in first position, but make it an error everywhere else.

@vtjnash
Copy link
Member

vtjnash commented Sep 13, 2018

Also, by setenv, I assume we mean, "all keyword args to the Cmd constructor (ignorestatus, env, dir, detach, windows_verbatim, windows_hide, flags)"

@StefanKarpinski
Copy link
Member

Triage decision:

  • if a command with environment is spliced into the first position in another command, then we should propagate the environment
  • if a command with environment is spliced into another command anywhere else, then it should be an error since we can't know what was intended

@StefanKarpinski StefanKarpinski added minor change Marginal behavior change acceptable for a minor release and removed triage This should be discussed on a triage call labels Sep 13, 2018
@StefanKarpinski StefanKarpinski added this to the 1.1 milestone Sep 13, 2018
@JeffBezanson JeffBezanson modified the milestones: 1.1, 1.2 Dec 6, 2018
@KristofferC KristofferC modified the milestones: 1.2, 1.x Apr 17, 2019
Keno added a commit that referenced this issue Apr 18, 2019
Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #25353
Keno added a commit that referenced this issue Apr 18, 2019
Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #25353
Keno added a commit that referenced this issue Apr 18, 2019
Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #24353
Keno added a commit that referenced this issue Apr 22, 2019
Too late for 1.2 for which this was originally marked, but nevertheless,
it's a quick change, so might as well get it in now and have it be available
in 1.3.

Fixes #24353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor change Marginal behavior change acceptable for a minor release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants