-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SparseVector #11424
[WIP] SparseVector #11424
Conversation
We will also need methods for |
As @StefanKarpinski suggested, let's make sure we have complete code coverage for this. |
Depending on the decision in #11408 |
The last commit of this PR passed tests (as shown by Travis-ci). The appveyor issue is unrelated. Of course, more tests are to be added. |
The AppVeyor failure is not unrelated. I can reproduce it by running |
Note: I am now working towards the NIPS 2015 submission deadline on June 6. Will resume the efforts here afterwards. |
Thanks for the update Dahua. Good luck with your submission. |
#11583 would be good to address here, once you get back to this. |
@lindahua Do you think we can do this in the next couple of weeks - which would make it possible to include in 0.4? |
I don't think I can have much time coding Julia in the coming month, as I have to kick start some new research projects. However, this is not a very difficult tasks, and I wish people interested in this PR can continue the efforts ... |
I am now resuming the efforts on this. |
I have a cleaned-up branch of this at https://github.com/JuliaLang/julia/tree/tk/sparsevec that you should start from, that at least passes tests. It doesn't address the unchecked items in the list up top though. |
Thanks, I will look into that. |
This PR is going to change the semantics of several functions (e.g. Also, many more functions are being actively implemented, tested, and tuned in the SparseVectors package. I am closing this, and will make another PR, when:
|
How do you plan on making the SparseVectors package correctly implement things that are currently buggy in base? Non-exported replacements like |
I am now adding |
Sounds reasonable. Will the package try to change base's indexing rules, returning a SparseVector from column slicing of a SparseMatrixCSC? I think that's the biggest most important change here that would be worth the possible breakage no matter when we decide to do it, but may as well do this right instead of rushing it. |
Sure, will explore the slicing stuff as next major step in the package development. Currently, we have |
Hearty bump! Any chance this could be revisited in the near future? Missing a real vector makes indexing into sparse matrices wonky. And it only gets stranger if we drop scalar dimensions — because then |
I figure maybe I have to say that I probably won't be able to find enough time to push forward this PR before mid November. The SparseVectors package has been quite stable. Anyone who are willing to push forward this please feel free to make a PR based on the whole / part / or none of that package. |
This is based on the discussion in #11324. This PR remains WIP, and it is doing the following:
SparseVector
type.SparseVector
type.SparseMatrix
andSparseVector
.