broadcast!(f, A, x::Number...) should call f(x...) independently for each A[i] #19799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
reviewed
Dec 31, 2016
| @@ -376,6 +376,7 @@ end | |||
|
|
|||
| # Check that broadcast!(f, A) populates A via independent calls to f (#12277, #19722). | |||
There was a problem hiding this comment.
Perhaps expand the test description with a note on broadcast!(f, A, x::Number...) and reference this pull request?
Sacha0
approved these changes
Dec 31, 2016
|
Looks great! Thanks for fixing this method! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects for an omission in #19722.
Technically, this is a breaking change compared to 0.5. However, it can also be viewed as a restoration of Julia-0.4 behavior that was unintentionally changed in 0.5, and which so far no one has noticed. (However, this will become much more important nowadays given dot-call syntax, e.g. if someone does
x .= rand.() .+ 1ala #19796.)