special show for AbstractVector{Method} for ::MIMEtext/plain #22068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
the
display and printing
Sacha0
reviewed
May 27, 2017
| print(io, "[$(i)] ") | ||
| show(io, m) | ||
| println(io) | ||
| push!(LAST_SHOWN_LINE_INFOS, (string(m.file), m.line)) |
There was a problem hiding this comment.
Thanks, hadn't pulled upstream in a few days :).
There was a problem hiding this comment.
Shouldn't this emtpy! the LAST_SHOWN_LINE_INFOS first?
which is currently done for text/html this enables the jump-to-method thingy from JuliaLang#22007 to be used with methodswith(Foo) also This also prevents large spacing in the printing, since the general vector output prints with equal spacing for all elements, and some methods have very long signatures
fredrikekre
force-pushed
the
fe/show-methodswith
branch
from
39f673f to
3f751e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently done for "text/html" do generate links to the methods. The REPL equivalent to links is #22007, so this enables that to be used with
methodswith(Foo)along withmethods(foo).This also prevents large spacing in the printing, since the general vector output prints with equal spacing for all elements (?), and some methods have very long signatures (try for instance
methodswith(SparseMatrixCSC))