-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
several accumulated cleanup items #27634
Conversation
@@ -10,7 +10,7 @@ module DelimitedFiles | |||
|
|||
using Mmap | |||
|
|||
import Base: _default_delims, tryparse_internal, show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this change is also included in #27605.
base/range.jl
Outdated
n == 0 && return () | ||
a = Vector{eltype(t)}(undef, n) | ||
o = first(r) - 1 | ||
@inbounds for i = 1:n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing any bounds-check (on t
) to make this annotation valid? I recommend just dropping it – it seems unlikely to make a performance difference
No description provided.