Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several accumulated cleanup items #27634

Merged
merged 7 commits into from
Jun 19, 2018
Merged

several accumulated cleanup items #27634

merged 7 commits into from
Jun 19, 2018

Conversation

JeffBezanson
Copy link
Member

No description provided.

@@ -10,7 +10,7 @@ module DelimitedFiles

using Mmap

import Base: _default_delims, tryparse_internal, show
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this change is also included in #27605.

base/range.jl Outdated
n == 0 && return ()
a = Vector{eltype(t)}(undef, n)
o = first(r) - 1
@inbounds for i = 1:n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing any bounds-check (on t) to make this annotation valid? I recommend just dropping it – it seems unlikely to make a performance difference

@JeffBezanson JeffBezanson merged commit c3f3b48 into master Jun 19, 2018
@JeffBezanson JeffBezanson deleted the jb/cleanup branch June 19, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants