Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make startswith, endswith work with Regex #29790

Merged
merged 17 commits into from
Feb 1, 2019
Merged

Make startswith, endswith work with Regex #29790

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c19fb82
Add `startswith`, `endswith` for `Regex`
dalum Oct 11, 2018
3193b3e
Add tests
dalum Oct 24, 2018
6560e5c
Use ANCHORED and ENDANCHORED instead of manipulating pattern
dalum Oct 25, 2018
16d6cd3
More tests
dalum Oct 25, 2018
0246784
Add docstrings
dalum Oct 25, 2018
4bad579
Update base/regex.jl
chethega Oct 28, 2018
8556e59
Update base/regex.jl
chethega Oct 28, 2018
8f21ef3
Update regex.jl
dalum Oct 29, 2018
1ff3b90
Update docstrings
dalum Oct 30, 2018
aebe2d4
Update regex.jl
dalum Oct 30, 2018
e0a0097
Update regex.jl
dalum Oct 30, 2018
fc03281
Update regex.jl
dalum Nov 3, 2018
880881a
Merge branch 'master' into dalum/regex
dalum Feb 1, 2019
b0d24cc
Update regex.jl
dalum Feb 1, 2019
641675b
merge
dalum Feb 1, 2019
0484632
Merge branch 'dalum/regex' of http://github.com/dalum/julia into dalu…
dalum Feb 1, 2019
aa27484
Fix docstring interpolation error
dalum Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions base/regex.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,11 @@ end
"""
startswith(s::AbstractString, prefix::Regex)

Return `true` if `s` starts with the regex pattern, `prefix`. Note:
`occursin` is recommended over the regex version of `startswith` in
performance critical situations.
Return `true` if `s` starts with the regex pattern, `prefix`.

!!! note
`occursin` is recommended over the regex version of `startswith`
in performance critical situations.
dalum marked this conversation as resolved.
Show resolved Hide resolved

See also [`occursin`](@ref) and [`endswith`](@ref).

Expand All @@ -204,9 +206,11 @@ end
"""
endswith(s::AbstractString, suffix::Regex)

Return `true` if `s` ends with the regex pattern, `suffix`. Note:
`occursin` is recommended over the regex version of `endswith` in
performance critical situations.
Return `true` if `s` ends with the regex pattern, `suffix`.

!!! note
`occursin` is recommended over the regex version of `endswith` in
performance critical situations.

See also [`occursin`](@ref) and [`startswith`](@ref).

Expand Down