Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder self-referential types checking to prevent inline allocation #33718

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

Liozou
Copy link
Member

@Liozou Liozou commented Oct 30, 2019

Fixes #33709

I added a small test right after those for #32448 but I can move, change or remove it if someone has a preference about it.

@vtjnash vtjnash merged commit b92a35d into JuliaLang:master Oct 30, 2019
@vtjnash
Copy link
Member

vtjnash commented Oct 30, 2019

Note that struct-layout is relying on inside_typedef currently to enforce that the computation ordering is structurally guaranteed. PRs that change that (such as #33553 and #32658) may need to rearrange this further and/or provide their own equivalent restrictions.

@Liozou Liozou deleted the recursiveuniontype branch October 30, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-recursive type definition with a Union segfaults
2 participants