Fix broken show method for Base.LogicalIndex

[karan0299]

Fixes #34364
julia> show(stdout, "text/plain", Base.LogicalIndex([true])) now shows the following output
1-element Base.LogicalIndex{Int64,Array{Bool,1}}: 1
Output is similar to that of collect method on LogicalIndex as suggested by @stevengj
In my opinion this is the appropriate change required.
Defined print_array(io,X::LogicalIndex) = print_array(io,collect(X))

[stevengj]

Should we change the 2-arg show as well?

[karan0299]

I think we should change show function with 2 args to maintain the consistency with the 3 args show method.
In my opinion output of show function with similar args i.e.
julia> show(stdout,Base.LogicalIndex([true,false,true])) should be displayed as
[1,3]
What is your opinion @stevengj ?

[karan0299]

I have updated the 2 args show method as well in last commit.

[stevengj]

As discussed in #34364, it seems like we may not want LogicalIndex to be a subtype of AbstractArray at all, in which case this implementation will have to change slightly.

[karan0299]

@stevengj as explained by Matt Bauman why he considers it to be a subtype of Abstract array in his comment "#34364 (comment)", is this fix fine?

[mbauman]

Failures are unrelated (a timeout and a distributed test failure).