Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about (un)shift to (push/pop)first docs #38823

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

tckmn
Copy link
Contributor

@tckmn tckmn commented Dec 10, 2020

This would be helpful for new users when searching for these functions via e.g. apropos().

This would be helpful for new users when searching for these functions
via e.g. apropos().
@ararslan ararslan added the docs This change adds or pertains to documentation label Dec 10, 2020
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good improvement. Thanks!

@carstenbauer
Copy link
Member

carstenbauer commented Dec 11, 2020

Why would one choose unshift as the name for a function that adds an element to the beginning of a collection? Seems super weird to me... Our pushfirst!/popfirst! names are so much better!

On a more general note, since when do we add such references to other programming languages naming conventions to docstrings? Isn't that what the "Noteworthy differences ..." section in the docs is for?

@KristofferC KristofferC merged commit c2b30f8 into JuliaLang:master Dec 11, 2020
@ararslan
Copy link
Member

Isn't that what the "Noteworthy differences ..." section in the docs is for?

I generally assumed that that was for structural/design differences between languages rather than naming/API.

@StefanKarpinski
Copy link
Member

That is why we didn't keep those names. Nevertheless that is what these are called in many other languages.

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
This would be helpful for new users when searching for these functions
via e.g. apropos().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants