Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small doc clearifications on embedding and the GC, plus information on threading restrictions #43966

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

paulmelis
Copy link
Contributor

While figuring out some embedding issues in a multi-threaded environment I found the docs to be a bit thin on details. So based on several discourse posts I added a section on thread-safety. Needs a check on correctness/completeness, though.

@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Jan 28, 2022
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you have a lot of trailing whitespace. Can you fix those?

    git rebase --whitespace=fix master

@inkydragon
Copy link
Member

whitespace — Passed

@ViralBShah LGTM

@ViralBShah ViralBShah merged commit 7014681 into JuliaLang:master Apr 6, 2022
@staticfloat
Copy link
Member

staticfloat commented Apr 6, 2022

I'm not sure how you checked whitespace, but all jobs are now failing with the following error:

Whitespace check found 1 issues:
doc/src/manual/embedding.md:682 -- trailing blank lines
make: *** [Makefile:104: check-whitespace] Error 1

You should use the buildkite whitespace job as the whitespace checker.

@ViralBShah
Copy link
Member

ViralBShah commented Apr 6, 2022

Sorry - I merged based on the comment. But the PR status shows that builkite reports whitespace passed.

@paulmelis
Copy link
Contributor Author

Whitespace check found 1 issues:
doc/src/manual/embedding.md:682 -- trailing blank lines
make: *** [Makefile:104: check-whitespace] Error 1

My patch only touches up to and including line 681, weird?

@vtjnash
Copy link
Member

vtjnash commented Apr 6, 2022

We made the test more strict since CI last ran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants